zachleat’s avatarzachleat’s Twitter Archive—№ 30,250

  1. Genuinely confused by GitHub here (and not just for their ICE stance). A PR that merges code *into* master is missing a line that clearly changes. Line 12 in the PR (no changes??): constructor(inputDir…) Master currently has an empty constructor: constructor() ???
    oh my god twitter doesn’t include alt text from images in their APIoh my god twitter doesn’t include alt text from images in their API
    On twitter.com Twitter logo zachleat’s avatar ❤️ 7 Favorites Mood -5 🙁
    1. …in reply to @zachleat
      The lesson I think I’m learning here is to never trust a GitHub diff on a PR that has merge conflicts—the diffs themselves are inaccurate!
      Permalink On twitter.com Twitter logo zachleat’s avatar ❤️ 6 Favorites Mood +1 🙂
      1. …in reply to @zachleat
        Tempted to delete this but against my nature I’m trying to be more vulnerable and learn things in public so… weeeeeee!
        Permalink On twitter.com Twitter logo zachleat’s avatar ❤️ 25 Favorites Mood -2 🙁
    2. …in reply to @zachleat
      Okay wow—TIL thanks to @franjohn21 that GitHub uses a “three-dot-diff” by default when I wanted the “two-dot-diff” @franjohn21/1235950940466737153 See help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-comparing-branches-in-pull-requests#three-dot-and-two-dot-git-diff-comparisons
      Permalink On twitter.com Twitter logo zachleat’s avatar ♻️ 1 Retweets ❤️ 12 Favorites Mood +2 🙂